Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): combine loading texts when multiple CommandTypes exist #9235

Closed
wants to merge 2 commits into from

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Jan 11, 2022

closes #9047

Overview

This PR combines the Move to Slot and Pick up Tip texts and the Move to Slot'and Return Tip' texts when the commands happen back to back.

Screen Shot 2022-01-11 at 15 42 19

Screen Shot 2022-01-11 at 15 41 37

Changelog

  • added onto the switch case to cover those conditions

Review requests

  • I tested on my robot but also test on your robot to make sure it works properly

Risk assessment

low, behind ff

@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #9235 (0130c60) into edge (03e3c55) will increase coverage by 0.79%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #9235      +/-   ##
==========================================
+ Coverage   74.89%   75.68%   +0.79%     
==========================================
  Files        1882     1321     -561     
  Lines       50167    40532    -9635     
  Branches     4938     2793    -2145     
==========================================
- Hits        37571    30677    -6894     
+ Misses      11704     9451    -2253     
+ Partials      892      404     -488     
Flag Coverage Δ
app 61.52% <ø> (-9.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...warePositionCheck/hooks/useLabwarePositionCheck.ts
app/src/redux/robot-api/selectors.ts
app/src/redux/robot-controls/constants.ts
...s/Calibrate/CalibrateLabware/CalibrationValues.tsx
app/src/redux/shell/update.ts
...tup/LabwarePositionCheck/LabwareOffsetsSummary.tsx
...pages/Calibrate/CalibrateLabware/InfoBoxButton.tsx
...sms/ProtocolSetup/RunSetupCard/ProceedToRunCta.tsx
...pages/Run/RunPanel/ModuleLiveStatusCards/index.tsx
...ttings/SelectNetwork/ConnectModal/KeyFileField.tsx
... and 551 more

@jerader jerader closed this Jan 12, 2022
@jerader jerader deleted the app_combine-robot-moving-modals branch January 12, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LPC screens with robot movement: combine 2 messages into one combined message
1 participant