-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(app): update sectionList text to reflect new design #9223
Conversation
Codecov Report
@@ Coverage Diff @@
## edge #9223 +/- ##
=======================================
Coverage 74.89% 74.89%
=======================================
Files 1882 1882
Lines 50167 50167
Branches 4938 4938
=======================================
Hits 37571 37571
Misses 11704 11704
Partials 892 892
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
count: sections.includes('SECONDARY_PIPETTE_TIPRACKS') | ||
? 2 | ||
: 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the use of count
as a pluralizer here is confusing to me. we tell i18n to pluralize the entry when there the user is in a two pipette flow, but it's hard to tell what that actually maps to. the pluralizer is really meant to change things like one item
to two items
. here we aren't actually pluralizing anything (as far as I can tell.). also it looks like depending on whether we're in a 1 pipette or 2 pipette workflow, the wording should be as follows:
1 pip flow:
Step 1: Check tipracks with Pipette and pick up a tip
// you actually have: Check tip racks with {{primary_mount}} Pipette and pick up a tip
Step 2: Check remaining labware with Pipette and tip
// you actually have: Check remaining labware with {{secondary_mount}} and tip
2 pip flow:
Step 2: Check tipracks with Right Pipette and pick up a tip
// you actually have: Check tip racks with {{primary_mount}} Pipette
Step 3: Check remaining labware with Right Pipette and tip
// this one looks correct
tbh i am confused because the image and text on the ticket say 2 different things... @emilywools is what jethary has here what you intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh good call, I was following what the images show in the ticket @emilywools please LMK if that's correct?
@shlokamin Also, I'm confused as to how this isn't a way to use count
as a pluralizer? We have several other areas in the repo where i18n plural is used to completely change the text: for example in protocol_setup.json
there is:
"module_setup_step_description": "Plug in and turn on the required module via the OT-2 USB Port. Place the module as shown in the deck map."
"module_setup_step_description_plural": "Plug in and turn on the required modules via the OT-2 USB Ports. Place the modules as shown in the deck map."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the example you have above looks like it's just changing module
=> modules
and port
=> ports
, which makes sense since its just pluralizing the subject nouns.
this is slightly different:
"primary_pipette_tipracks_section": "Check tip racks with {{primary_mount}} Pipette and pick up a tip",
"primary_pipette_tipracks_section_plural": "Check tip racks with {{primary_mount}} Pipette",
we're not really pluralizing anything here, so when I read this, I'm sort of confused as to what the singular/plural text for primary_pipette_tipracks_section
means. we don't change anything from singular to plural, we're really just adding and pick up tip
when it's "singular"
hey @jerader Jethary, I think overall what you have is correct, but Shlok grabbed a 2-pipette workflow screenshot, and the "pick up a tip" belongs with step 2, not step 1. Does that make sense? |
Not the same protocol that Shlok used but fixed the issue. Here is what it looks like now with 2 pipettes: @emilywools @shlokamin |
this looks good to me, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
closes #9159
Overview
This PR updates the text on the steps in
sectionList
Changelog
Review requests
Risk assessment
low, behind ff