Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): make protocol setup whole background gray #9122

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Dec 16, 2021

closes #9120

Overview

This makes the background behind the accordion steps and metadata card the same light gray color C_NEAR_WHITE

Screen Shot 2021-12-16 at 09 29 52

Changelog

  • Added background color to protocolSetup/index

Review requests

  • review above picture, review on your own robot - it is a super subtle difference and hard to see

Risk assessment

low, behind ff

@jerader jerader requested a review from a team as a code owner December 16, 2021 14:32
@jerader jerader requested review from brenthagen and removed request for a team December 16, 2021 14:32
@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #9122 (114614a) into edge (053f676) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge    #9122   +/-   ##
=======================================
  Coverage   74.79%   74.79%           
=======================================
  Files        1867     1867           
  Lines       49741    49741           
  Branches     4903     4903           
=======================================
  Hits        37204    37204           
  Misses      11675    11675           
  Partials      862      862           
Flag Coverage Δ
app 69.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/src/organisms/ProtocolSetup/index.tsx 88.00% <ø> (ø)

@jerader jerader requested review from shlokamin, sakibh, smb2268 and a team and removed request for a team December 16, 2021 14:32
Copy link
Contributor

@sakibh sakibh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jerader jerader merged commit 0a236c6 into edge Dec 16, 2021
@jerader jerader deleted the app_gray-background-pur branch December 16, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gray background stops on accordion page
2 participants