refactor(app): make protocol upload failed banner absolute #9089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
commented
Dec 13, 2021
| title={t('protocol_upload_failed')} | ||
| <Flex | ||
| position="absolute" | ||
| flexDirection={DIRECTION_COLUMN} |
There was a problem hiding this comment.
for some reason I needed to add this flexDirection, otherwise the banner wouldn't span the whole width (even though I have the width = 100%)
Codecov Report
@@ Coverage Diff @@
## edge #9089 +/- ##
==========================================
+ Coverage 74.79% 75.73% +0.94%
==========================================
Files 1866 1309 -557
Lines 49710 40205 -9505
Branches 4895 2791 -2104
==========================================
- Hits 37182 30451 -6731
+ Misses 11671 9351 -2320
+ Partials 857 403 -454
Flags with carried forward coverage won't be shown. Click here to find out more. |
sakibh
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9050
Overview
this PR makes the protocol upload failed banner absolute so it doesn't take up a ton of room and cause extra space above the protocol upload stuff (which looks weird especially if the error is long)
Changelog
Review requests
Risk assessment
low, behind ff