refactor(app): confirm exit modal to appear over run details and run panel #9067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## edge #9067 +/- ##
=======================================
Coverage 74.76% 74.76%
=======================================
Files 1867 1867
Lines 49650 49650
Branches 4891 4891
=======================================
Hits 37120 37120
Misses 11673 11673
Partials 857 857
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jerader
requested review from
sakibh and
b-cooper
and removed request for
mcous
|
@emilywools should the background be black? I can't remember |
|
full screen workflows (like robot calibration) use a black background. this modal background looks correct to me |
mcous
pushed a commit
that referenced
this pull request
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9053
Overview
This PR adds a portal to the confirm exit modal so it appears over the run details and run panel rather than only appearing over the run details.
Changelog
Review requests
Risk assessment
low, behind ff