Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): lPC generic step screen align items and italicize text #8974

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Dec 2, 2021

closes #8959

Overview

This PR aligns deckMap sectionList and LabwarePositionCheckStepDetail components on the genericStepScreen and italicizes the labware name in the text

Changelog

  • removed some unnecessary formatting and added italics and aligned items

Review requests

  • review ticket's AC and figma to make sure everything looks good:

Screen Shot 2021-12-02 at 16 26 12

Screen Shot 2021-12-02 at 16 24 28

Risk assessment

low, behind ff

@jerader jerader requested a review from a team as a code owner December 2, 2021 21:32
@jerader jerader requested review from X-sam, shlokamin and b-cooper and removed request for a team and X-sam December 2, 2021 21:32
@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #8974 (40be4cb) into edge (ba6a9a1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge    #8974   +/-   ##
=======================================
  Coverage   74.72%   74.72%           
=======================================
  Files        1860     1860           
  Lines       49411    49411           
  Branches     4858     4858           
=======================================
  Hits        36922    36922           
  Misses      11644    11644           
  Partials      845      845           
Flag Coverage Δ
app 69.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...olSetup/LabwarePositionCheck/GenericStepScreen.tsx 100.00% <ø> (ø)
...rePositionCheck/LabwarePositionCheckStepDetail.tsx 100.00% <ø> (ø)
...tocolSetup/LabwarePositionCheck/StepDetailText.tsx 100.00% <ø> (ø)

Copy link
Contributor

@b-cooper b-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 📦

@b-cooper b-cooper merged commit 8c5e802 into edge Dec 3, 2021
@b-cooper b-cooper deleted the app_lpc-generic-step-screen-refactoring branch December 3, 2021 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LPC generic step align items and italicize labware name
2 participants