Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(app): update Labware Help Modal #8558

Merged
merged 6 commits into from
Oct 22, 2021
Merged

refactor(app): update Labware Help Modal #8558

merged 6 commits into from
Oct 22, 2021

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Oct 19, 2021 •
edited
Loading

Overview

closes #8325

Changelog

  • moves modal to be in Labware Position Check and Offset Data section in Labware setup accordion
  • updates modal to match figma
  • renamed LabwareSetupModal to LabwareOffsetModal to describe the information in the new modal better

Review requests

  • review to make sure styling, text, and links are correct

Risk assessment

low, behind ff

@codecov
Copy link

codecov bot commented Oct 19, 2021 •
edited
Loading

Codecov Report

Merging #8558 (7d04288) into edge (283df4a) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #8558      +/-   ##
==========================================
+ Coverage   74.42%   74.45%   +0.02%     
==========================================
  Files        1685     1685              
  Lines       45518    45564      +46     
  Branches     4551     4564      +13     
==========================================
+ Hits        33878    33924      +46     
  Misses      10847    10847              
  Partials      793      793
Flag Coverage Δ
app 71.62% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...p/RunSetupCard/LabwareSetup/LabwareOffsetModal.tsx 100.00% <100.00%> (ø)
.../ProtocolSetup/RunSetupCard/LabwareSetup/index.tsx 91.66% <100.00%> (+8.33%) ⬆️
...sms/ProtocolSetup/LabwarePositionCheck/DeckMap.tsx 82.75% <0.00%> (-2.96%) ⬇️
app/src/molecules/JogControls/DirectionControl.tsx 85.71% <0.00%> (ø)
...olSetup/LabwarePositionCheck/GenericStepScreen.tsx 100.00% <0.00%> (ø)
...rePositionCheck/LabwarePositionCheckStepDetail.tsx 95.23% <0.00%> (+11.90%) ⬆️

@jerader jerader changed the title feat(app): update Labware Help Modal refactor(app): update Labware Help Modal Oct 19, 2021
@jerader jerader added the app Affects the `app` project label Oct 19, 2021
@jerader jerader marked this pull request as ready for review October 19, 2021 20:54
@jerader jerader requested a review from a team as a code owner October 19, 2021 20:54
@jerader jerader requested review from shlokamin and removed request for a team October 19, 2021 20:54
jerader
jerader commented Oct 19, 2021
View reviewed changes
app/src/organisms/ProtocolSetup/RunSetupCard/LabwareSetup/LabwareOffsetModal.tsx Outdated
const ROBOT_CAL_HELP_ARTICLE =
'https://support.opentrons.com/en/articles/3499692-how-positional-calibration-works-on-the-ot-2'

const OFFSET_DATA_HELP_ARTICLE = '#' // REPLACE WITH ACTUAL LINK
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emily said the article this is supposed to link to doesn't exist yet

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add a TODO: IMMEDIATELY to this comment as a reminder that this needs to be addressed before release.

@jerader
Copy link
Collaborator Author

jerader commented Oct 20, 2021

Hi @emilywools, please review the following and let me know how everything looks! Thanks 😄

Screen Shot 2021-10-20 at 08 56 20

Screen Shot 2021-10-20 at 08 56 43

>

@emilywools
Copy link

hey Jethary, this looks great! One thing: the spacing before the "learn more about xx" and after should be different. Before the link, the paragraph spacing should be a little bit less so it looks like it belongs with the paragraph above it.

@jerader
Copy link
Collaborator Author

jerader commented Oct 20, 2021

hey Jethary, this looks great! One thing: the spacing before the "learn more about xx" and after should be different. Before the link, the paragraph spacing should be a little bit less so it looks like it belongs with the paragraph above it.

@emilywools, thanks for noticing that! I did have extra spacing. How is this?
Screen Shot 2021-10-20 at 10 15 21

@emilywools
Copy link

LGTM!!!

b-cooper
b-cooper approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@b-cooper b-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's make sure to flag the missing article link as an immediate TODO

app/src/organisms/ProtocolSetup/RunSetupCard/LabwareSetup/LabwareOffsetModal.tsx Outdated
const ROBOT_CAL_HELP_ARTICLE =
'https://support.opentrons.com/en/articles/3499692-how-positional-calibration-works-on-the-ot-2'

const OFFSET_DATA_HELP_ARTICLE = '#' // REPLACE WITH ACTUAL LINK
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add a TODO: IMMEDIATELY to this comment as a reminder that this needs to be addressed before release.

@jerader jerader merged commit 29f7900 into edge Oct 22, 2021
@jerader jerader deleted the app_lpc-update-labware-help-modal branch October 22, 2021 20:37
@shlokamin shlokamin mentioned this pull request Oct 25, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilywools emilywools emilywools approved these changes

@b-cooper b-cooper b-cooper approved these changes

@shlokamin shlokamin Awaiting requested review from shlokamin shlokamin is a code owner automatically assigned from Opentrons/js

Assignees
No one assigned
Labels
app Affects the `app` project
Projects
None yet
Milestone
No milestone
Deve