-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(js-api-clients): move js-api-clients to the opentrons repo #8515
Conversation
Codecov Report
@@ Coverage Diff @@
## edge #8515 +/- ##
==========================================
- Coverage 74.21% 74.20% -0.01%
==========================================
Files 1691 1704 +13
Lines 45502 45805 +303
Branches 4619 4707 +88
==========================================
+ Hits 33768 33989 +221
- Misses 10941 11009 +68
- Partials 793 807 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think double nesting these projects inside js-api-clients
may be confusing, and I'd be softly in favor of not doing that. Otherwise, various comments about integrating the config of these configs into the monorepo more consistently
69c8e81
to
8bebc9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for now, we need to come back and address the hacks I added once we upgrade to react 16.14
, link to slack thread
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. A few final cleanup items, but nothing major
f479803
to
0324402
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☑️
Overview
Move
js-api-clients
to the/opentrons
monorepo to allow for use of shared data typesChangelog
Moved all
js-api-clients
files to monorepoAdded necessary dev dependencies to root
package.json
Fixed linting & TS errors
Added CI yaml file for
js-api-clients
Review requests
Ensure existing
example-app
is still working as expectedRisk assessment
Low