Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(app): extend SectionList component for Generic Step Screen #8513

Merged
merged 12 commits into from
Oct 13, 2021
Merged

feat(app): extend SectionList component for Generic Step Screen #8513

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2698e2f
add section props to generic step screen
jerader Oct 11, 2021
d719074
create positionchecknav test
jerader Oct 12, 2021
9ef3247
feat(app): extend PositionCheckNav component for Generic Step Screen
jerader Oct 12, 2021
71c2404
increase test coverage
jerader Oct 12, 2021
ed03c83
clean up file
jerader Oct 12, 2021
3261c8a
add compeltedSections prop value
jerader Oct 13, 2021
870023b
remove extra spaces
jerader Oct 13, 2021
8e4e4b7
fix genericStepScreen styling
jerader Oct 13, 2021
4ebbb0c
revert export function change back to export const
jerader Oct 13, 2021
a28ca07
rename PositionCheckNav to SectionList
jerader Oct 13, 2021
2da5499
fix jest test
jerader Oct 13, 2021
5c8c579
address pr changes
jerader Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(app): extend PositionCheckNav component for Generic Step Screen 
closes #8500
  • Loading branch information
@jerader
jerader committed Oct 12, 2021
commit 9ef324770a3a56ccc98b36432f46a3a2390a3c01
6 changes: 3 additions & 3 deletions app/src/organisms/ProtocolSetup/LabwarePositionCheck/__tests__/GenericStepScreen.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const PICKUP_TIP_LABWARE_ID = 'PICKUP_TIP_LABWARE_ID'
const PRIMARY_PIPETTE_ID = 'PRIMARY_PIPETTE_ID'
const MOCK_SECTION = ['PRIMARY_PIPETTE_TIPRACKS' as Section]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this variable represents multiple sections, can we call it MOCK_SECTIONS (plural)?


const MOCK_LABWARE_POSITION_CHECK_STEP_TIP_RACK = {
const MOCK_LABWARE_POSITION_CHECK_STEP_TIPRACK = {
labwareId:
'1d57fc10-67ad-11ea-9f8b-3b50068bd62d:opentrons/opentrons_96_filtertiprack_200ul/1',
section: '',
Expand All @@ -55,13 +55,13 @@ describe('GenericStepScreen', () => {

beforeEach(() => {
props = {
selectedStep: MOCK_LABWARE_POSITION_CHECK_STEP_TIP_RACK,
selectedStep: MOCK_LABWARE_POSITION_CHECK_STEP_TIPRACK,
setCurrentLabwareCheckStep: () => {},
}
when(mockLabwarePositionCheckStepDetail)
.calledWith(
partialComponentPropsMatcher({
selectedStep: MOCK_LABWARE_POSITION_CHECK_STEP_TIP_RACK,
selectedStep: MOCK_LABWARE_POSITION_CHECK_STEP_TIPRACK,
})
)
.mockReturnValue(<div>Mock Labware Position Check Step Detail</div>)
Expand Down