refactor(app): fix LPC button #8502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## edge #8502 +/- ##
==========================================
+ Coverage 74.24% 74.25% +0.01%
==========================================
Files 1692 1692
Lines 45504 45504
Branches 4619 4619
==========================================
+ Hits 33784 33790 +6
+ Misses 10926 10919 -7
- Partials 794 795 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jerader
requested review from
shlokamin and
Kadee80
and removed request for
a team
shlokamin
approved these changes
Oct 11, 2021
Comment on lines
+119
to
+127
| it('should call setCurrentLabwareCheckStep when the CTA button is pressed', () => { | ||
| const { getByRole } = render(props) | ||
| expect(props.setCurrentLabwareCheckStep).not.toHaveBeenCalled() | ||
| const genericStepScreenButton = getByRole('button', { | ||
| name: 'begin labware position check, move to Slot 2', | ||
| }) | ||
| fireEvent.click(genericStepScreenButton) | ||
| expect(props.setCurrentLabwareCheckStep).toHaveBeenCalled() | ||
| }) |
There was a problem hiding this comment.
hell yeah, thanks for this @jerader!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8494
Overview
closes ticket 8494
Changelog
introScreenbuttonlabwarePositionCheck.indextestReview requests
Risk assessment
low, behind ff