Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add notify-server to .eslintignore #8045

Merged
merged 1 commit into from
Jul 1, 2021
Merged

chore: Add notify-server to .eslintignore #8045

merged 1 commit into from
Jul 1, 2021

Conversation

SyntaxColoring
Copy link
Contributor

This makes make js-lint ignore the notify-server directory.

Without this, if you do a top-level make test followed by a top-level make lint, you get this error:

prettier --ignore-path .eslintignore --check ".*.@(js|ts|tsx|yml)" "**/*.@(ts|tsx|js|json|md|yml)"
Checking formatting...
[warn] notify-server/.pytest_cache/README.md
[warn] Code style issues found in the above file(s). Forgot to run Prettier?

Because pytest autogenerates a README.md that doesn't match Prettier's style.

@SyntaxColoring SyntaxColoring requested a review from a team as a code owner July 1, 2021 15:54
@SyntaxColoring SyntaxColoring changed the title chore: Add notify-server to eslintgnore chore: Add notify-server to .eslintignore Jul 1, 2021
@SyntaxColoring SyntaxColoring merged commit b2bbe25 into edge Jul 1, 2021
@SyntaxColoring SyntaxColoring deleted the eslintignore_notify_server branch July 1, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitlissack amitlissack amitlissack approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SyntaxColoring @amitlissack