Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(labware-library): add tip rack test .py protocol #8020

Merged
merged 1 commit into from
Jun 29, 2021
Merged

feat(labware-library): add tip rack test .py protocol #8020

merged 1 commit into from
Jun 29, 2021

Conversation

IanLondon
Copy link
Contributor

Overview

Closes #7884. Take Jethary's tiprack protocol and template-ify it!

Changelog

  • template-ify Jethary's protocol and hook it up so it's saved
  • now that we have more than one protocol template, put them in a new folder

Review requests

  • code review
  • manually test. If someone can check this on a robot, that would be good, but we can wait until QA. The saved protocol should upload to Run App correctly (with real robot or robot dev server)

Risk assessment

Medium, LC only

@IanLondon IanLondon requested review from a team, shlokamin and smb2268 and removed request for a team June 28, 2021 19:24
@IanLondon IanLondon force-pushed the lc_add-tiprack-test-protocol-7884 branch from 9477d25 to bf763c2 Compare June 28, 2021 19:38
@IanLondon IanLondon requested a review from jerader June 28, 2021 19:43
jerader
jerader approved these changes Jun 29, 2021
View reviewed changes
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Ran it on the robot and it worked correctly.
Tested:

200uL tiprack with p300s GEN2

@IanLondon IanLondon merged commit 174dad9 into edge Jun 29, 2021
@IanLondon IanLondon deleted the lc_add-tiprack-test-protocol-7884 branch June 29, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerader jerader jerader approved these changes

@shlokamin shlokamin Awaiting requested review from shlokamin

@smb2268 smb2268 Awaiting requested review from smb2268

Assignees
No one assigned
Labels
labware creator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom Tiprack Test Python Protocol
2 participants
@IanLondon @jerader