Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(components): regenerate flow-types #8014

Merged
merged 1 commit into from
Jul 1, 2021
Merged

refactor(components): regenerate flow-types #8014

merged 1 commit into from
Jul 1, 2021

Conversation

IanLondon
Copy link
Contributor

Overview

Somehow, these got behind. This PR is just the result of running:

rm -rf components/flow-type/*
make -C components flow-types

Changelog

Review requests

  • Seems more correct than before?
  • CI still passing?

Risk assessment

Low

@IanLondon IanLondon requested review from a team and shlokamin and removed request for a team June 25, 2021 20:47
shlokamin
shlokamin approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@shlokamin shlokamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 LGTM

@IanLondon IanLondon merged commit d561d1c into edge Jul 1, 2021
@IanLondon IanLondon deleted the cl_update-flow-types branch July 1, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlokamin shlokamin shlokamin approved these changes

Assignees
No one assigned
Labels
JS Tech Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IanLondon @shlokamin