Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add save functions for user labware definitions and offsets #799

Merged
merged 1 commit into from
Feb 12, 2018

Conversation

btmorr
Copy link
Contributor

@btmorr btmorr commented Feb 9, 2018

overview

Adds save functions for user definitions and offset files in new labware definition format.

Fixes #796

changelog

  • (feature) Add save functions for user definitions and offset files in new labware definition format

@btmorr btmorr added api Affects the `api` project ready for review labware labels Feb 9, 2018
@btmorr btmorr self-assigned this Feb 9, 2018
@codecov
Copy link

codecov bot commented Feb 9, 2018

Codecov Report

Merging #799 into v3a will increase coverage by 0.04%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##              v3a     #799      +/-   ##
==========================================
+ Coverage   69.26%   69.31%   +0.04%     
==========================================
  Files         193      193              
  Lines        6231     6247      +16     
  Branches      191      191              
==========================================
+ Hits         4316     4330      +14     
- Misses       1852     1854       +2     
  Partials       63       63
Impacted Files Coverage Δ
api/opentrons/data_storage/serializers.py 100% <100%> (ø) ⬆️
api/opentrons/data_storage/labware_definitions.py 90.9% <85.71%> (-1.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78de681...9c46405. Read the comment docs.

Copy link
Contributor

@andySigler andySigler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@btmorr btmorr merged commit b1e7dd9 into v3a Feb 12, 2018
@btmorr btmorr deleted the api_add-labware-safe-fns branch February 12, 2018 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Affects the `api` project labware
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants