Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list function and compatibility test for all new labware #795

Merged
merged 1 commit into from
Feb 9, 2018

Conversation

btmorr
Copy link
Contributor

@btmorr btmorr commented Feb 9, 2018

overview

Add function to list all available labware and add compatibility test for all labware available in new format.

Fixes #766

changelog

  • (feature) Add function to list all labware in new system
  • (tests) Add compatibility test for all labware in new system

@btmorr btmorr added feature Ticket is a feature request / PR introduces a feature api Affects the `api` project ready for review small labware labels Feb 9, 2018
@btmorr btmorr self-assigned this Feb 9, 2018
@btmorr btmorr force-pushed the api_new-labware-compatibility-test branch from ef38eb7 to 18cf803 Compare February 9, 2018 20:26
@codecov
Copy link

codecov bot commented Feb 9, 2018

Codecov Report

Merging #795 into v3a will increase coverage by 0.09%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              v3a     #795      +/-   ##
==========================================
+ Coverage   69.16%   69.26%   +0.09%     
==========================================
  Files         193      193              
  Lines        6221     6231      +10     
  Branches      191      191              
==========================================
+ Hits         4303     4316      +13     
+ Misses       1855     1852       -3     
  Partials       63       63
Impacted Files Coverage Δ
api/opentrons/data_storage/labware_definitions.py 92.3% <93.33%> (+8.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c2014b...18cf803. Read the comment docs.

Copy link
Contributor

@andySigler andySigler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@btmorr btmorr merged commit 78de681 into v3a Feb 9, 2018
@btmorr btmorr deleted the api_new-labware-compatibility-test branch February 9, 2018 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Affects the `api` project feature Ticket is a feature request / PR introduces a feature labware small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants