feat(labware-creator): autofill homogenousWells for tipRacks #7806
Conversation
There was a problem hiding this comment.
I know a lot of this is moving stuff around, but i think it's worth adding test coverage around CreateNewDefinition now that's its doing more than it used to. Would also be nice to have makeAutofillOnChange and _getIsAutofilled tested, but also understand this is legacy code that has not been touched in a while.
| Partial<LabwareFields> | ||
| > = { | ||
| tipRack: { | ||
| homogeneousWells: 'true' as const, |
There was a problem hiding this comment.
just read about as const, pretty cool! the idea here is that labwareTypeAutofills is readonly and cannot be changed?
There was a problem hiding this comment.
yup but I did it less completely than I could. Fixed in #7814
There was a problem hiding this comment.
oh it also fixes as error where 'true' by itself got inferred as string instead of BooleanString = 'true' | 'false'
| @@ -104,8 +104,15 @@ context('File Import', () => { | |||
| cy.get("input[placeholder='testpro_15_wellplate_5ul']").should('exist') | |||
|
|
|||
| // Test pipette | |||
| cy.contains('Select...').click({ force: true }) | |||
| cy.contains('P10 Single GEN1').click({ force: true }) | |||
| // TODO(IL, 2021-05-15): give Dropdown component semantic selectors for E2E | |||
There was a problem hiding this comment.
oof ya we should def throw in selectors
|
|
||
| expect(getByRole('heading')).toHaveTextContent(/create a new definition/i) | ||
| expect(getByText(/what type of labware are you creating\?/i)).toBeTruthy() | ||
| expect(getByRole('button')).toHaveTextContent(/start creating labware/i) |
There was a problem hiding this comment.
nice, i will def be referring to this test the next time i use testing library!
Overview
Pairing credit to @Kadee80
Addresses #7712 -- just regularity section
Changelog
Review requests
Risk assessment
Low