Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Enable audio on GPIO startup #5787

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

theosanderson
Copy link
Contributor

overview

The GPIO pin that allows the Pi to output audio was automatically enabled prior to the upgrade to libgpiod #5381 . This is relied upon by e.g. this test

, and allows users to make their robots make sounds.

This should restore that functionality by enabling this pin during GPIO setup.

Do close this if it was an active decision to deprecate audio (but that seems a shame given it is the only way the OT2 has to communicate autonomously)

changelog

  • adds function to control audio_enable_pin and calls out to it during setup

review requests

@ahiuchingau seems to be the expert on this

risk assessment

  • setup function should already be covered by tests?
  • this will restore speaker functionality so might cause a robot's speaker to emit noise if it has a hardware fault and has only been used/tested since the libgpiod update, but this is quite recent!

The GPIO pin that allows the Pi to output audio was automatically enabled prior to Opentrons#5381 . This is relied upon by e.g. this test https://github.com/Opentrons/opentrons/blob/751d9a402fa5d1f936df43ed12fd7387be23237f/api/src/opentrons/tools/factory_test.py#L217, and allows users to make their robots make sounds.

This should restore that functionality by enabling this pin during GPIO setup.
@theosanderson theosanderson requested a review from a team as a code owner June 1, 2020 17:41
@theosanderson
Copy link
Contributor Author

I can't see how the JS build breakage can be related, but let me know if you think it is

Copy link
Contributor

@ahiuchingau ahiuchingau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice catch! LGTM

@sfoster1 sfoster1 merged commit 907401c into Opentrons:edge Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants