Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat(api): adds response formatting to api requests … #5206

Closed
wants to merge 7 commits into from

Conversation

iansolano
Copy link
Contributor

Please wait to review - have a couple of quick cleanups first. TY!

overview

changelog

review requests

@iansolano iansolano added WIP robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). labels Mar 11, 2020
@iansolano iansolano requested review from a team as code owners March 11, 2020 14:44
@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #5206 into edge will decrease coverage by 17.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             edge    #5206       +/-   ##
===========================================
- Coverage   60.29%   43.15%   -17.14%     
===========================================
  Files        1025      875      -150     
  Lines       29062    13072    -15990     
===========================================
- Hits        17522     5641    -11881     
+ Misses      11540     7431     -4109
Impacted Files Coverage Δ
components/src/deck/RobotCoordsForeignDiv.js 33.33% <0%> (-66.67%) ⬇️
...col-designer/src/components/DeckSetup/ModuleTag.js 55.17% <0%> (-26.65%) ⬇️
...igner/src/components/DeckSetup/getModuleVizDims.js 40% <0%> (-20%) ⬇️
app/src/analytics/selectors.js 14.28% <0%> (-14.29%) ⬇️
protocol-designer/src/ui/modules/utils.js 0% <0%> (-12.5%) ⬇️
app/src/protocol/selectors.js 80.95% <0%> (-0.59%) ⬇️
...signer/src/components/LiquidPlacementForm/index.js 0% <0%> (ø) ⬆️
...omponents/CalibrateLabware/ConfirmModalContents.js 0% <0%> (ø) ⬆️
protocol-designer/src/components/FilePage.js 0% <0%> (ø) ⬆️
...igner/src/components/LiquidsPage/LiquidEditForm.js 0% <0%> (ø) ⬆️
... and 158 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b15d360...7710e64. Read the comment docs.

@iansolano iansolano force-pushed the api_fastapi-json-response-patterns branch from 943f730 to 7710e64 Compare March 11, 2020 15:35
@iansolano iansolano closed this Mar 11, 2020
@iansolano iansolano deleted the api_fastapi-json-response-patterns branch March 11, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). WIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant