-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(labware-library): refactor default to named exports #4860
Conversation
Codecov Report
@@ Coverage Diff @@
## edge #4860 +/- ##
==========================================
+ Coverage 67.62% 67.62% +<.01%
==========================================
Files 1057 1058 +1
Lines 35541 35544 +3
==========================================
+ Hits 24034 24037 +3
Misses 11507 11507
Continue to review full report at Codecov.
|
1889a47
to
4b50790
Compare
d742d1f
to
2394ead
Compare
2c2a1b9
to
9f4fe5e
Compare
2394ead
to
e1a2cff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just two little things:
- We need to make sure the
App
export is thehot
one (discussed in person) - Looks like a PD component got pulled into this PR
Dropping this link here for my future testing reference: https://sandbox.labware.opentrons.com/ll_named-exports/
04c80ec
to
fe9bcaa
Compare
afbc56d
to
4baf232
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍸
4baf232
to
cfde8d2
Compare
Refactor default to named exports in support of linter changes
#4830
overview
changelog
review requests