Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(labware-library): refactor default to named exports #4860

Merged
merged 8 commits into from
Feb 6, 2020

Conversation

iansolano
Copy link
Contributor

Refactor default to named exports in support of linter changes

#4830

overview

changelog

review requests

@iansolano iansolano added chore WIP robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). labels Jan 27, 2020
@codecov
Copy link

codecov bot commented Jan 27, 2020

Codecov Report

Merging #4860 into edge will increase coverage by <.01%.
The diff coverage is 23.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #4860      +/-   ##
==========================================
+ Coverage   67.62%   67.62%   +<.01%     
==========================================
  Files        1057     1058       +1     
  Lines       35541    35544       +3     
==========================================
+ Hits        24034    24037       +3     
  Misses      11507    11507
Impacted Files Coverage Δ
...ry/src/components/website-navigation/MobileMenu.js 0% <ø> (ø) ⬆️
...onents/website-navigation/ProtocolMobileContent.js 0% <ø> (ø) ⬆️
...-library/src/labware-creator/labwareDefToFields.js 88.88% <ø> (ø) ⬆️
labware-library/src/components/Sidebar/index.js 100% <ø> (ø) ⬆️
labware-library/src/components/App/Page.js 100% <ø> (ø) ⬆️
...y/src/labware-creator/components/LabwareCreator.js 0% <ø> (ø) ⬆️
.../src/components/website-navigation/ProtocolMenu.js 0% <ø> (ø) ⬆️
...brary/src/components/website-navigation/NavMenu.js 0% <ø> (ø) ⬆️
...ary/src/components/LabwareDetails/InsertDetails.js 0% <ø> (ø) ⬆️
...ware-library/src/components/Sidebar/FilterReset.js 0% <ø> (ø) ⬆️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28a0eca...cfde8d2. Read the comment docs.

@iansolano iansolano force-pushed the ll_named-exports branch 2 times, most recently from d742d1f to 2394ead Compare January 29, 2020 21:05
@iansolano iansolano changed the title style(labware-library): [WIP] refactor default to named exports style(labware-library): refactor default to named exports Jan 30, 2020
Copy link
Contributor

@mcous mcous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just two little things:

  • We need to make sure the App export is the hot one (discussed in person)
  • Looks like a PD component got pulled into this PR

Dropping this link here for my future testing reference: https://sandbox.labware.opentrons.com/ll_named-exports/

labware-library/src/components/App/index.js Outdated Show resolved Hide resolved
protocol-designer/src/containers/ConnectedMainPanel.js Outdated Show resolved Hide resolved
Copy link
Contributor

@mcous mcous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍸

@iansolano iansolano changed the base branch from pd_named-exports to edge February 6, 2020 20:52
@iansolano iansolano merged commit fe03d60 into edge Feb 6, 2020
@iansolano iansolano deleted the ll_named-exports branch February 6, 2020 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants