-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(protocol-designer): change default exports to named exports #4834
Conversation
af0e875
to
989f884
Compare
Codecov Report
@@ Coverage Diff @@
## edge #4834 +/- ##
=========================================
- Coverage 67.71% 67.62% -0.1%
=========================================
Files 1056 1057 +1
Lines 35491 35540 +49
=========================================
+ Hits 24033 24034 +1
- Misses 11458 11506 +48
Continue to review full report at Codecov.
|
2c2a1b9
to
9f4fe5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is mostly good! Noticed a few little things to grab since right now the app crashes but I'm hopeful these are the only ones
Change default exports to named exports in app and app-shell
Refactor default exports to named exports to fix linter warnings #4830
04c80ec
to
fe9bcaa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for all the fish
Caught a couple things in PD while testing that we should fix up at some point, but I think we should merge this PR as is and get these in another PR to be done with this (and also they're outside the scope of "named export refactor")
- Add missing
// @flow
toprotocol-designer/src/modules/index.js
- Delete completely empty file
protocol-designer/src/step-generation/utils/mergeLiquid.js
Refactor default exports to named exports to fix linter warnings
#4830
overview
changelog
review requests