Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(protocol-designer): change default exports to named exports #4834

Merged
merged 9 commits into from
Feb 6, 2020

Conversation

iansolano
Copy link
Contributor

Refactor default exports to named exports to fix linter warnings

#4830

overview

changelog

review requests

@iansolano iansolano added chore WIP robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). labels Jan 23, 2020
@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

Merging #4834 into edge will decrease coverage by 0.09%.
The diff coverage is 34.55%.

Impacted file tree graph

@@            Coverage Diff            @@
##             edge    #4834     +/-   ##
=========================================
- Coverage   67.71%   67.62%   -0.1%     
=========================================
  Files        1056     1057      +1     
  Lines       35491    35540     +49     
=========================================
+ Hits        24033    24034      +1     
- Misses      11458    11506     +48
Impacted Files Coverage Δ
...load-file/migration/utils/v1LabwareModelToV2Def.js 9.09% <ø> (ø) ⬆️
...rotocol-designer/src/networking/opentronsWebApi.js 0% <ø> (ø) ⬆️
...designer/src/components/FileSidebar/FileSidebar.js 0% <ø> (ø) ⬆️
...ientsList/LabwareDetailsCard/LabwareDetailsCard.js 0% <ø> (ø) ⬆️
protocol-designer/src/steplist/utils/index.js 88.88% <ø> (ø) ⬆️
protocol-designer/src/components/ForeignDiv.js 0% <ø> (ø) ⬆️
...ol-designer/src/top-selectors/substep-highlight.js 0% <ø> (ø) ⬆️
...ponents/StepEditForm/fields/DisposalVolumeField.js 0% <ø> (ø) ⬆️
...mponents/modals/FilePipettesModal/PipetteFields.js 0% <ø> (ø) ⬆️
...col-designer/src/components/steplist/IngredPill.js 0% <ø> (ø) ⬆️
... and 191 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6423f71...bbebcd8. Read the comment docs.

@iansolano iansolano requested a review from mcous January 27, 2020 20:20
@iansolano iansolano requested a review from a team January 27, 2020 20:20
@iansolano iansolano changed the title style(protocol-designer): [WIP] change default exports to named exports style(protocol-designer): change default exports to named exports Jan 27, 2020
@iansolano iansolano changed the base branch from app_named-exports to edge January 27, 2020 20:31
@iansolano iansolano changed the title style(protocol-designer): change default exports to named exports style(protocol-designer): [WIP] change default exports to named exports Jan 27, 2020
@iansolano iansolano force-pushed the pd_named-exports branch 2 times, most recently from 2c2a1b9 to 9f4fe5e Compare January 29, 2020 22:10
@iansolano iansolano changed the title style(protocol-designer): [WIP] change default exports to named exports style(protocol-designer): change default exports to named exports Jan 30, 2020
Copy link
Contributor

@mcous mcous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is mostly good! Noticed a few little things to grab since right now the app crashes but I'm hopeful these are the only ones

protocol-designer/src/index.js Outdated Show resolved Hide resolved
protocol-designer/src/index.js Outdated Show resolved Hide resolved
Copy link
Contributor

@mcous mcous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for all the fish

Caught a couple things in PD while testing that we should fix up at some point, but I think we should merge this PR as is and get these in another PR to be done with this (and also they're outside the scope of "named export refactor")

  • Add missing // @flow to protocol-designer/src/modules/index.js
  • Delete completely empty file protocol-designer/src/step-generation/utils/mergeLiquid.js

@iansolano iansolano merged commit 7f73718 into edge Feb 6, 2020
@mcous mcous deleted the pd_named-exports branch February 6, 2020 22:12
@mcous mcous restored the pd_named-exports branch February 6, 2020 22:54
mcous added a commit that referenced this pull request Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants