Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(app): change default exports to named exports #4822

Merged
merged 2 commits into from
Jan 27, 2020
Merged

Conversation

iansolano
Copy link
Contributor

@iansolano iansolano commented Jan 21, 2020

Change default exports to named exports in app and app-shell

overview

I'm trying to fix these linter warning in chunks to make merging and reviewing easier. This is the first bit, more to come. 😅

I will use this as the base branch and merge all the corresponding PRs into this branch

changelog

review requests

Change default exports to named exports in app and app-shell
@iansolano iansolano requested a review from a team January 21, 2020 22:03
@iansolano iansolano added chore robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). WIP ready for review and removed WIP labels Jan 21, 2020
Copy link
Contributor

@mcous mcous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug due to inconsistent naming of the export from app-shell/src/log.js uncaught by flow due to low flow coverage in app-shell.

I think I'm also gonna ask to avoid arbitrary switching function declarations to anonymous arrow functions while we don't have consensus

app-shell/src/log.js Outdated Show resolved Hide resolved
@iansolano iansolano changed the title style(app): change default exports to named exports style(app): [WIP] change default exports to named exports Jan 22, 2020
@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

Merging #4822 into edge will increase coverage by 0.27%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             edge   #4822      +/-   ##
=========================================
+ Coverage   57.92%   58.2%   +0.27%     
=========================================
  Files         956     960       +4     
  Lines       26237   26822     +585     
=========================================
+ Hits        15199   15611     +412     
- Misses      11038   11211     +173
Impacted Files Coverage Δ
app-shell/src/ui.js 0% <ø> (ø) ⬆️
app-shell/src/buildroot/release-files.js 0% <ø> (ø) ⬆️
app/src/shell/epic.js 100% <ø> (ø) ⬆️
app/src/analytics/selectors.js 14.28% <ø> (ø) ⬆️
app-shell/src/update.js 100% <ø> (ø) ⬆️
app-shell/src/buildroot/index.js 0% <ø> (ø) ⬆️
app/src/util.js 100% <ø> (ø) ⬆️
app/src/analytics/hash.js 14.28% <ø> (ø) ⬆️
app/src/logger.js 0% <ø> (ø) ⬆️
app/src/analytics/mixpanel.js 13.04% <ø> (ø) ⬆️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5351183...98bb5a0. Read the comment docs.

@iansolano iansolano changed the title style(app): [WIP] change default exports to named exports style(app): change default exports to named exports Jan 27, 2020
@iansolano iansolano requested review from mcous and a team January 27, 2020 20:19
Copy link
Contributor

@mcous mcous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎂

Smoke tested dev and prod builds on my mac and everything looks good

@iansolano iansolano merged commit a1ee7f7 into edge Jan 27, 2020
@mcous mcous deleted the app_named-exports branch February 13, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants