Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): remove unnecessary tip return #4566

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

iansolano
Copy link
Contributor

@iansolano iansolano commented Dec 9, 2019

This PR is pulling double duty as a bug report

In return tip, labware return tip was being called explicitly even though it was called implicitly
under drop_tip

This shouldn't change anything behaviorally but removes unnecessary error message

In return tip, labware return tip was being called explicitly even though it was called implicitly
under drop_tip
@iansolano iansolano added bug api Affects the `api` project ready for review fix PR fixes a bug papi-v2 Python API V2 labels Dec 9, 2019
@iansolano iansolano requested a review from a team December 9, 2019 16:34
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch

@codecov
Copy link

codecov bot commented Dec 9, 2019

Codecov Report

Merging #4566 into edge will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge    #4566      +/-   ##
==========================================
- Coverage   57.39%   57.39%   -0.01%     
==========================================
  Files         920      920              
  Lines       25809    25805       -4     
==========================================
- Hits        14814    14810       -4     
  Misses      10995    10995
Impacted Files Coverage Δ
opentrons/protocol_api/contexts.py 87.8% <0%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddc2800...6582b41. Read the comment docs.

@iansolano iansolano merged commit 94df11e into edge Dec 9, 2019
@iansolano iansolano deleted the api_remove-unnecessary-tip-return branch December 9, 2019 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Affects the `api` project bug fix PR fixes a bug papi-v2 Python API V2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants