fix(APIV2): Make tipracks always calibrate from top #4418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## edge #4418 +/- ##
==========================================
- Coverage 55.93% 55.93% -0.01%
==========================================
Files 900 900
Lines 25538 25540 +2
==========================================
Hits 14285 14285
- Misses 11253 11255 +2
Continue to review full report at Codecov.
|
Laura-Danielle
approved these changes
Nov 14, 2019
There was a problem hiding this comment.
Tested on a robot in-house. Able to successfully calibrate multiple times in a row and run protocols without crashing.
Thanks for the contribution @theosanderson!
|
Thanks for the test! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
"Calibrate to bottom" when enabled prevents tiprack calibration working as described in #4417. This should fix that.
Fixes #4417.
changelog
Prevents calibration to bottom having any effect for tipracks.
review requests
Haven't tested this as I don't have a dev environment setup yet, but can confirm things are broken at present and logically this should work.