Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shared-data): swap XY spacing for 24-well nest tuberacks #4266

Closed
wants to merge 1 commit into from

Conversation

sfoster1
Copy link
Member

24-well nest tuberack spacing for X and Y was swapped relative to what it should be (X was Y, Y was X). This PR targets the fix onto master for a hotfix release.

@sfoster1 sfoster1 added fix PR fixes a bug shared data Affects the `shared-data` project labels Oct 22, 2019
@sfoster1 sfoster1 requested a review from a team October 22, 2019 13:38
@codecov
Copy link

codecov bot commented Oct 22, 2019

Codecov Report

Merging #4266 into edge will increase coverage by 3.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            edge    #4266      +/-   ##
=========================================
+ Coverage   56.3%   59.77%   +3.47%     
=========================================
  Files        877      886       +9     
  Lines      24830    28392    +3562     
=========================================
+ Hits       13980    16971    +2991     
- Misses     10850    11421     +571
Impacted Files Coverage Δ
...te-server/otupdate/buildroot/ssh_key_management.py 26.8% <0%> (-2.75%) ⬇️
components/src/nav/NavButton.js 84.61% <0%> (-1.1%) ⬇️
update-server/otupdate/buildroot/__init__.py 34.28% <0%> (-1.01%) ⬇️
opentrons/deck_calibration/dc_main.py 58.89% <0%> (-0.8%) ⬇️
components/src/instrument/PipetteSelect.js 12.12% <0%> (-0.7%) ⬇️
protocol-designer/src/configureStore.js 3.57% <0%> (-0.43%) ⬇️
opentrons/server/endpoints/serverlib_fallback.py 72.61% <0%> (-0.04%) ⬇️
...library/src/labware-creator/components/Dropdown.js 0% <0%> (ø) ⬆️
app/src/components/MenuPanel/index.js 0% <0%> (ø) ⬆️
shared-data/js/helpers/wellSets.js 100% <0%> (ø) ⬆️
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fce8347...ec043c4. Read the comment docs.

Copy link
Contributor

@Laura-Danielle Laura-Danielle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to bump version down to 1 for all the defs and overwrite old definitions -- not sure if we want to take Morgan's idea of putting old defs in custom_beta folder

@sfoster1 sfoster1 closed this Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix PR fixes a bug shared data Affects the `shared-data` project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants