Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APIv2 Docs #4120

Closed
wants to merge 19 commits into from
Closed

APIv2 Docs #4120

wants to merge 19 commits into from

Conversation

wheresaddie
Copy link

changelog

review requests

@wheresaddie
Copy link
Author

round 1 v2 edits

sfoster1
sfoster1 requested changes Sep 27, 2019
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple typos. It's also inline, but good point about the browser compatibility. Per https://jupyter-notebook.readthedocs.io/en/stable/notebook.html#browser-compatibility , we are compatible with up to date Chrome, Safari, and Firefox and Opera and Edge "should work" but aren't explicitly tested.

api/docs/source/v2/apiv2index.rst Outdated Show resolved Hide resolved
api/docs/source/v2/apiv2index.rst Outdated Show resolved Hide resolved
api/docs/source/v2/apiv2index.rst Outdated Show resolved Hide resolved
api/docs/source/v2/new_advanced_running.rst Outdated Show resolved Hide resolved
api/docs/source/v2/new_advanced_running.rst Outdated Show resolved Hide resolved
api/docs/source/v2/new_labware.rst Outdated Show resolved Hide resolved
api/docs/source/v2/new_modules.rst Outdated Show resolved Hide resolved
api/docs/source/v2/new_modules.rst Outdated Show resolved Hide resolved
api/docs/source/v2/new_pipette.rst Outdated Show resolved Hide resolved
api/docs/source/v2/new_pipette.rst Outdated Show resolved Hide resolved
wheresaddie and others added 9 commits September 28, 2019 13:06
@wheresaddie @sfoster1
Update api/docs/source/v2/new_pipette.rst
f85601d 
Co-Authored-By: Seth Foster <[email protected]>
@wheresaddie @sfoster1
Update api/docs/source/v2/new_advanced_running.rst
b541dc0 
Co-Authored-By: Seth Foster <[email protected]>
@wheresaddie @sfoster1
Update api/docs/source/v2/apiv2index.rst
fe30f8e 
Co-Authored-By: Seth Foster <[email protected]>
@wheresaddie @sfoster1
Update api/docs/source/v2/apiv2index.rst
7591734 
Co-Authored-By: Seth Foster <[email protected]>
@wheresaddie @sfoster1
Update api/docs/source/v2/apiv2index.rst
89458dd 
Co-Authored-By: Seth Foster <[email protected]>
@wheresaddie @sfoster1
Update api/docs/source/v2/new_labware.rst
30e6fd5 
Co-Authored-By: Seth Foster <[email protected]>
@wheresaddie @sfoster1
Update api/docs/source/v2/new_modules.rst
7a928ac 
Co-Authored-By: Seth Foster <[email protected]>
@wheresaddie @sfoster1
Update api/docs/source/v2/new_modules.rst
a053d6f 
Co-Authored-By: Seth Foster <[email protected]>
@wheresaddie @sfoster1
Update api/docs/source/v2/new_pipette.rst
e5a500e 
Co-Authored-By: Seth Foster <[email protected]>
sfoster1
sfoster1 requested changes Sep 30, 2019
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good, let's just insert the browser compatibility notes here since these docs go live when merged.

api/docs/source/v2/new_advanced_running.rst Outdated Show resolved Hide resolved
wheresaddie
wheresaddie commented Oct 3, 2019
View reviewed changes
Copy link
Author

@wheresaddie wheresaddie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

wheresaddie
wheresaddie commented Oct 3, 2019
View reviewed changes
Copy link
Author

@wheresaddie wheresaddie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@wheresaddie wheresaddie closed this Oct 3, 2019
@wheresaddie
Copy link
Author

round 1 of edits for APIv2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcous mcous mcous left review comments

@sfoster1 sfoster1 sfoster1 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wheresaddie @mcous @sfoster1