Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set plunger to 'bottom' during pick-up-tip to avoid firmware bug #245

Merged
merged 1 commit into from
Jun 14, 2017

Conversation

andySigler
Copy link
Contributor

A user discovered a new bug, where given a special combination of coordinates, the AB motors squeal again during pipette._position_for_aspirate() where the plunger is set to bottom position.

This patch sets the plunger to bottom position during pipette.pick_up_tip() to avoid this moment all together. However, the long-term solution will be to switch to a newer build of smoothieware EDGE that fixes this bug.

This issue has not been reported by any other user.

@coveralls
Copy link

coveralls commented Jun 14, 2017

Coverage Status

Coverage increased (+0.001%) to 91.212% when pulling 69a2d1d on pick-up-tip-firmware-bug-patch into b26aaf9 on master.

@andySigler andySigler merged commit 01bb884 into master Jun 14, 2017
@andySigler andySigler deleted the pick-up-tip-firmware-bug-patch branch June 14, 2017 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants