Beta toggle #240
Closed
Beta toggle #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimplyAhmazing
commented
Jun 8, 2017
| @@ -92,3 +121,30 @@ def tag_from_ci_env_vars(ci_name, pull_request_var, branch_var, commit_var): | |||
| return None | |||
|
|
|||
|
|
|||
| def republish_win_s3(yml_file, exe_file): | |||
There was a problem hiding this comment.
this can be deleted..
SimplyAhmazing
commented
Jun 8, 2017
| os.environ['CHANNEL'] = 'beta' | ||
| elif 'CHANNEL' not in os.environ: | ||
| # os.environ['CHANNEL'] = 'dev' | ||
| os.environ['CHANNEL'] = 'beta' |
There was a problem hiding this comment.
this should be removed and previous line is uncommented before merge into master
|
Also wanted to note that from this feature onwards, releases for win and mac through auto-updater will be dictated by S3 buckets. Particularly We can do a few trial releases using git tags to test this new deployment setup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements beta toggle in the app. Several things here,
18.4.0-- the latest wasn't quite stable for me but this version iselectronandspectronversions ==> we may have resolved the rendering issues on OSX 10.10 because of this updateapp-shell/package.jsonto remove unneeded depsHow the feature works,
File > Use Beta App. Wait a few minutes and restart the app in order to get beta buildFile > Use Beta App. Wait a few minutes. A popup will come alerting that there's a new versionThis feature is possible because the latest
electron-builderallows for channels for updating. There is astablechannel and abetachannel. These channels are tracked in S3 folders. When the app builds on master an app artifact is pushed to the S3betabucket. When the app is built on in a release tag the resulting artifact is pushed to the S3stablefolder.When the app builds a beta that beta is labeled with the
patchandbuildnumber are cantor and shifted by+1000. This is because the electron-updater recognizes build updates only when the major, minor, or patch has increased. But when neither one of those has increased and only the build (which represents a commit from versioneer) has increased it is not noticeable to the updater. The patch number is shifted by a 1000 s.t. that when the app loads it determines that if the patch # less a 1000 is greater than 0, then this is a beta build and it should therefore cantor decode the patch number.