feat(compute): Use IPv4 link-local ethernet networking #1970

btmorr · 2018-07-31T18:03:56Z

overview

OT2s have been having connectivity problems for ethernet connections. It appears that we were previously using a non-standard way of assigning an IPv6 link-local address. This PR does the following:

use nmcli instead of ip addr to configure the port (nmcli has access to the host OS, ip addr does not)
assign an IPv4 address in a valid link-local address space (169.254/16 instead of fd00:0:cafe:fefe::/64)
modify the bind statements to work with correct link-local addressing (not able to count on all robots having one exact IP address)
remove radvd (only used for IPv6)

Relates to #1964

Outstanding changes (to be addressed in another PR that @mcous has already started):

client changes are needed to find robots with the new address range
make tasks need to be updated to find the robot's address rather than relying on a single static address

changelog

use nmcli instead of ip addr to configure the port
assign an IPv4 address in a valid link-local address space
modify the bind statements to work with correct link-local addressing
remove radvd

review requests

Tested on moon-moon and young-moon, robots showing up in the Run App as WiFi when they're connected over ethernet.

…g nmcli

codecov · 2018-07-31T18:43:34Z

Codecov Report

Merging #1970 into edge will decrease coverage by 0.46%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             edge   #1970      +/-   ##
=========================================
- Coverage   32.16%   31.7%   -0.47%     
=========================================
  Files         429     430       +1     
  Lines        6867    7217     +350     
=========================================
+ Hits         2209    2288      +79     
- Misses       4658    4929     +271

Impacted Files	Coverage Δ
protocol-designer/src/steplist/utils.js	`90.62% <0%> (-9.38%)`	⬇️
...tocol-designer/src/file-data/selectors/commands.js	`19.31% <0%> (-2.56%)`	⬇️
...-designer/src/top-selectors/well-contents/index.js	`47.05% <0%> (-0.95%)`	⬇️
...tocol-designer/src/components/steplist/StepItem.js	`0% <0%> (ø)`	⬆️
...tocol-designer/src/containers/ConnectedTitleBar.js	`0% <0%> (ø)`	⬆️
...designer/src/components/steplist/TimelineAlerts.js	`0% <0%> (ø)`	⬆️
protocol-designer/src/steplist/generateSubsteps.js	`0% <0%> (ø)`	⬆️
protocol-designer/src/containers/Alerts.js	`0% <0%> (ø)`	⬆️
...rotocol-designer/src/containers/SelectablePlate.js	`0% <0%> (ø)`	⬆️
...tocol-designer/src/components/steplist/StepList.js	`0% <0%> (ø)`	⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb7f107...6a193b7. Read the comment docs.

…apter

Laura-Danielle

🐷

Kadee80

🍜

mcous · 2018-08-01T18:12:04Z

Dockerfile

@@ -19,8 +19,8 @@ ENV OT_UPDATE_PORT=34000
 ENV OT_SERVER_UNIX_SOCKET_PATH=/tmp/aiohttp.sock

 # Static IPv6 used on Ethernet interface for USB connectivity
-ENV ETHERNET_STATIC_IP=fd00:0000:cafe:fefe::1
-ENV ETHERNET_NETWORK_PREFIX=fd00:0000:cafe:fefe::
+ENV ETHERNET_STATIC_IP=fe80::3c68:f2a4:a5f8:58bf


As per our discussion, this won't work right? Should we remove this line?

mcous · 2018-08-01T18:12:57Z

api-server-lib/Makefile

@@ -4,7 +4,7 @@ SHELL := /bin/bash
 PATH := $(shell cd .. && yarn bin):$(PATH)

 # make push host
-host ?= \[fd00:0:cafe:fefe::1\]
+host ?= \[fe80::3c68:f2a4:a5f8:58bf\]


Rather than slot something in for host that only works for one robot, can we remove this line (or comment it out). Passing host in as a make env var will still work without it

mcous · 2018-08-01T18:13:01Z

api/Makefile

@@ -6,7 +6,7 @@ SHELL := /bin/bash
 PATH := $(shell cd .. && yarn bin):$(PATH)

 # make push host
-host ?= \[fd00:0:cafe:fefe::1\]
+host ?= \[fe80::3c68:f2a4:a5f8:58bf\]


Same comment about hardcoding this value

mcous

🥇 so pleased with the switch to IPv4

mcous · 2018-08-01T22:14:56Z

Dockerfile

@@ -19,9 +19,8 @@ ENV OT_UPDATE_PORT=34000
 ENV OT_SERVER_UNIX_SOCKET_PATH=/tmp/aiohttp.sock

 # Static IPv6 used on Ethernet interface for USB connectivity


Comment now out of date but whatever

mcous · 2018-08-01T22:16:56Z

compute/conf/nginx.conf

@@ -46,7 +46,7 @@ http {
 root /usr/share/nginx/html;

 client_max_body_size 100m;
- listen local-ethernet default_server ipv6only=on;
+ listen [::] default_server ipv6only=on;


Should ipv6only=on still be set? Or is this server block only for ipv6?

That listen statement is ipv6 only. Can be ripped out later, but it's not the worst to leave the server listening on ipv6 also even though we're not currently using it

refactor(compute): Configure ethernet port in host OS instead of usin…

1a11c4c

…g nmcli

btmorr added api Affects the `api` project easyfix Ticket is an easy fix; good for first time contributors labels Jul 31, 2018

fix(compute): Use correctly formed link-local address for ethernet ad…

b48da97

…apter

btmorr force-pushed the compute_eth-on-host branch from 5eb042d to b48da97 Compare August 1, 2018 16:41

btmorr requested a review from mcous August 1, 2018 16:52

btmorr added feature Ticket is a feature request / PR introduces a feature fix PR fixes a bug medium and removed easyfix Ticket is an easy fix; good for first time contributors labels Aug 1, 2018

btmorr requested review from Kadee80 and Laura-Danielle August 1, 2018 16:56

btmorr removed the fix PR fixes a bug label Aug 1, 2018

Laura-Danielle approved these changes Aug 1, 2018

View reviewed changes

Kadee80 approved these changes Aug 1, 2018

View reviewed changes

mcous suggested changes Aug 1, 2018

View reviewed changes

btmorr changed the title ~~Refactor ethernet networking on robot~~ feat(compute): Use IPv4 link-local ethernet networking Aug 1, 2018

Switch ethernet to IPv4

6a193b7

btmorr force-pushed the compute_eth-on-host branch from 2a6db76 to 6a193b7 Compare August 1, 2018 21:06

mcous approved these changes Aug 1, 2018

View reviewed changes

btmorr merged commit 094ca28 into edge Aug 2, 2018

btmorr deleted the compute_eth-on-host branch August 2, 2018 14:06

IanLondon mentioned this pull request Aug 2, 2018

chore(release): 3.3.0-beta.1 #2001

Merged

mcous mentioned this pull request Aug 20, 2018

feat(app): Enable support for IPv4 wired robots by default #2090

Merged

20 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(compute): Use IPv4 link-local ethernet networking #1970

feat(compute): Use IPv4 link-local ethernet networking #1970

btmorr commented Jul 31, 2018 •

edited

Loading

codecov bot commented Jul 31, 2018 •

edited

Loading

Laura-Danielle left a comment

Kadee80 left a comment

mcous Aug 1, 2018

mcous Aug 1, 2018

mcous Aug 1, 2018

mcous left a comment

mcous Aug 1, 2018

mcous Aug 1, 2018

btmorr Aug 2, 2018

		@@ -19,9 +19,8 @@ ENV OT_UPDATE_PORT=34000
		ENV OT_SERVER_UNIX_SOCKET_PATH=/tmp/aiohttp.sock

		# Static IPv6 used on Ethernet interface for USB connectivity

feat(compute): Use IPv4 link-local ethernet networking #1970

feat(compute): Use IPv4 link-local ethernet networking #1970

Conversation

btmorr commented Jul 31, 2018 • edited Loading

overview

changelog

review requests

codecov bot commented Jul 31, 2018 • edited Loading

Codecov Report

Laura-Danielle left a comment

Choose a reason for hiding this comment

Kadee80 left a comment

Choose a reason for hiding this comment

mcous Aug 1, 2018

Choose a reason for hiding this comment

mcous Aug 1, 2018

Choose a reason for hiding this comment

mcous Aug 1, 2018

Choose a reason for hiding this comment

mcous left a comment

Choose a reason for hiding this comment

mcous Aug 1, 2018

Choose a reason for hiding this comment

mcous Aug 1, 2018

Choose a reason for hiding this comment

btmorr Aug 2, 2018

Choose a reason for hiding this comment

btmorr commented Jul 31, 2018 •

edited

Loading

codecov bot commented Jul 31, 2018 •

edited

Loading