-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(api): Add GEB tiprack definition to default containers #1658
Conversation
@Laura-Danielle should we call this the opentrons-tiprack-300ul? Assuming this is for the custom tipracks GEB manufactures for Opentrons, not the off-the-shelf GEB tipracks. |
b2c0aa9
to
2e74d3f
Compare
@umbhau I am not opposed to changing the name. @btmorr @pantslakz @howisthisnamenottakenyet thoughts? |
Codecov Report
@@ Coverage Diff @@
## edge #1658 +/- ##
==========================================
+ Coverage 34.62% 34.64% +0.01%
==========================================
Files 340 343 +3
Lines 5533 5813 +280
==========================================
+ Hits 1916 2014 +98
- Misses 3617 3799 +182
Continue to review full report at Codecov.
|
Not opposed to more specific naming. |
|
2e74d3f
to
f98fa05
Compare
The more specific naming, in my opinion, the better. If the tip-rack has a part number, that should be either in the name, or specified some other way. It is 100% conceivable that we will have a rev2 or even totally different design of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍘
Pending CI fix |
@andySigler raises a really good point about labware revisions. I'm ok with this PR going in (especially to fix up OT2 docs weirdness) but we should discuss how new versions of a given definition are going to play out |
GEB tiprack needs to be added to default containers for customers who are not utilizing split_definitions feature flag. Also, there was a typo in the docs about the GEB tiprack definition name.
f98fa05
to
84831dc
Compare
@mcous @andySigler I think that's definitely something to keep in mind moving forward. We should definitely have a discussion about how to handle revisions/model numbers and where they live. |
happy we're ridding of GEB in place of Opentrons |
overview
GEB tiprack needs to be added to default containers for customers who are not utilizing
split_definitions feature flag. Also, there was a typo in the docs about the GEB tiprack definition
name.
changelog
review requests