fix(app): Fix scrolling behind long press modals #16206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix RQA-3139
Overview
On both protocol details and now quick transfer on ODD, if you have enough protocols for the page to be scrollable, you are able to scroll the long press modal and overlay out of view when it is open. This has likely been the case on the protocols page since this change #15166
Test Plan and Hands on Testing
On ODD, look at protocol tab and long press a protocol. See that the page is locked and you can't scroll the background. Repeat for quick transfer tab
Changelog
Put the
LegacyModalShellin a top level portal where used inMenuListwhich is the container for the long press modalsReview requests
Quick code check, I tested this out
Risk assessment
Low