refactor(protocol-designer): merge top level routes into Designer route #16066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
commented
Aug 20, 2024
| @@ -79,7 +79,6 @@ export function NavigationBar({ | |||
| padding={`${SPACING.spacing12} ${SPACING.spacing40}`} | |||
| gridGap={SPACING.spacing40} | |||
| > | |||
| TODO add breadcrumbs here | |||
There was a problem hiding this comment.
latest designs removed breadcrumbs so i removed this todo
ncdiehl11
approved these changes
Aug 20, 2024
protocol-designer/src/assets/localization/en/starting_deck_state.json
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Merge
startingDeckStateandprotocolStepsinto 1 route calledDesignerto accommodate new designsTest Plan and Hands on Testing
make sure the nav works as expected when on the protocol overview. The nav bar button
Edit protocoland clicking "edit" in the Protocol Deck section should navigate to theDesignertabChangelog
combine routes and make
DeckSetupa folder withinDesignerfix all imports
Review requests
see test plan
Risk assessment
low