feat(api): add innner well geometry to labware definitions #15975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxColoring
requested changes
Aug 13, 2024
shared-data/python/opentrons_shared_data/labware/labware_definition.py
Outdated
Show resolved
Hide resolved
shared-data/python/opentrons_shared_data/labware/labware_definition.py
Outdated
Show resolved
Hide resolved
shared-data/python/opentrons_shared_data/labware/labware_definition.py
Outdated
Show resolved
Hide resolved
shared-data/python/opentrons_shared_data/labware/labware_definition.py
Outdated
Show resolved
Hide resolved
shared-data/python/opentrons_shared_data/labware/labware_definition.py
Outdated
Show resolved
Hide resolved
shared-data/python/opentrons_shared_data/labware/labware_definition.py
Outdated
Show resolved
Hide resolved
shared-data/python/opentrons_shared_data/labware/labware_definition.py
Outdated
Show resolved
Hide resolved
shared-data/python/opentrons_shared_data/labware/labware_definition.py
Outdated
Show resolved
Hide resolved
shared-data/python/opentrons_shared_data/labware/labware_definition.py
Outdated
Show resolved
Hide resolved
SyntaxColoring
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add the Labware Definition types for static liquid tracking to shared-data.
Each labware defintion will now have an optional
innerWellGeometryentry. This will be a list ofBoundedSections, as well as abottomShape.A
Bounded Sectionwill represent either a 'frustum' or a hemisphere- a subsection of a well with a uniform shape. It will hold aTopCrossSection, and will carry theheightof the top cross-section of the shape it represents.bottomShapewill denote whether the bottom of a well is aSphericalSection, or a flat plane. It will also hold all of the necessary data to compute either the surface area or volume of the bottom section of the wellTopCrossSectionwill hold all the data necessary to calculate the area of the top cross-section of itsBoundedSection.