Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): Add Error Recovery takeover banners #15841

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Jul 30, 2024

Closes EXEC-633 and EXEC-420

Overview

Adds error recovery takeover banners on the desktop's Devices and DeviceDetail pages. Note that these banners only show when a user is actively engaged in error recovery on a different device.

DeviceDetails

Screenshot 2024-07-30 at 3 07 03 PM Screenshot 2024-07-30 at 3 07 31 PM

Devices

Screenshot 2024-07-30 at 3 46 04 PM

Test Plan and Hands on Testing

  • See pics

Changelog

  • Added desktop banners info banners whenever a different device is actively engaged in Error Recovery.

Risk assessment

low

@mjhuff mjhuff requested a review from a team July 30, 2024 20:05
@mjhuff mjhuff requested a review from a team as a code owner July 30, 2024 20:05
@mjhuff mjhuff requested review from ncdiehl11 and removed request for a team and ncdiehl11 July 30, 2024 20:05
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, Redux, my old friend

@mjhuff mjhuff merged commit a4197cb into edge Jul 30, 2024
26 checks passed
@mjhuff mjhuff deleted the app_add-desktop-takeover-banners branch July 30, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants