build: Sign windows builds via remote key storage #15718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrates code signing with a key stored in digicert one to app build workflows. There are a couple caveats: - You can do this locally if you have a windows machine and if you have the right accounts and permissions. Read: you basically can't do this locally - Digicert for some reason charges per signature. We sign a lot of stuff. Therefore, we are only going to produce signed windows builds for releases and if a dev really needs to by pushing a branch that has "as-release" in it (in the same way we only do app builds if you push a branch that has app-build in it - so building and signing both windows apps would require a branch that has app-build-both-as-release in it) - This just doesn't work at all with electron-builder, and they don't seem to want to change things to fix it; specifically, you can only configure e-b to pass along a key link and a password, and you basically can't do that anymore. So we have to have a (thankfully simple) custom sign script. Closes RDEVOPS-128
6ff6c2c
to
d764028
Compare
vegano1
approved these changes
Jul 22, 2024
| forceCodeSigning: WINDOWS_SIGN, | ||
| rfc3161TimeStampServer: 'https://timestamp.digicert.com', | ||
| sign: 'scripts/windows-custom-sign.js', | ||
| signDlls: true, |
There was a problem hiding this comment.
Do we need to take into account timestamp server rate-limiting, per this comment?
There was a problem hiding this comment.
digicert's timestamp server is rate limited to 100 request/5s and 1000 request/5min which I don't think we would hit unless doing about 8 windows builds at the same time (we sign ~60 files), which should be very rare.
y3rsh
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
All makes sense to me. Thanks for taking care of it.
https://builds.opentrons.com/app/Opentrons-v7.3.1-win-b45460-RDEVOPS-128-fix-windows-signing-app-build-both-as-release.exe
Has the new certificate.
y3rsh
pushed a commit
that referenced
this pull request
Jul 22, 2024
Integrates code signing with a key stored in digicert one to app build workflows. There are a couple caveats: - You can do this locally if you have a windows machine and if you have the right accounts and permissions. Read: you basically can't do this locally - Digicert for some reason charges per signature. We sign a lot of stuff. Therefore, we are only going to produce signed windows builds for releases and if a dev really needs to by pushing a branch that has "as-release" in it (in the same way we only do app builds if you push a branch that has app-build in it - so building and signing both windows apps would require a branch that has app-build-both-as-release in it) - This just doesn't work at all with electron-builder, and they don't seem to want to change things to fix it; specifically, you can only configure e-b to pass along a key link and a password, and you basically can't do that anymore. So we have to have a (thankfully simple) custom sign script. Closes RDEVOPS-128 ## to leave draft - [x] this produces a signed installer that passes smartscreen - [x] this only does that on branches with the right kinds of names
y3rsh
added a commit
that referenced
this pull request
Jul 22, 2024
## `cherry-pick` 246efcb Must update `chore_release-7.4.0` so that windows builds work and we may test an update. To understand the changes see #15718 Co-authored-by: Seth Foster <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates code signing with a key stored in digicert one to app build workflows.
There are a couple caveats:
Closes RDEVOPS-128
to leave draft