Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new button that is in the app components. Its existence is a bit tricky.
This is a kind of button that is just text of a particular color with particular hover states - no background color, no border, etc. It's meant to be the lowest-visual-priority interactable it can be.
We have a component that does this, for the ODD only. It's the tertiaryLowLight state of SmallButton, which you can see in the ODD/Atoms/Buttons tree in storybook. This component definitely wasn't and isn't responsive to desktop styles.
Separately, we heavily used buttons of this style in the modern wizards: PipetteWizard, GripperWizard, LPC. These wizards all define their content bodies via GenericWizardTile, whose stories are under App/Molecules/GenericWizardTile, and that component had a completely separate definition of this button style as a styled-component inline in its implementation.
Now, we want to use a button of that style on desktop, but in Error Recovery, which is a flow that doesn't use GenericWizardTile (because it needs the border look&feel of InterventionModal). So the button needs to be defined outside of GenericWizardTile, and also it needs to be responsive. That means we could do one of the following:
I picked 4. I don't really feel that great about it. Also it's used in ER footer and so that should look correct now.
Testing
Do GenericWizardTile stories still look rightwell, uh, probably not that useful