fix(api): prevent stalls on PickUpTip Protocol API command #15663
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Recently in ABR testing, we've seen significant stalls surface from the head boards. One possible culprit is
_move_to_plunger_bottom()
now occurring aftertip_pickup_moves()
. This PR moves_move_to_plunger_bottom()
back to beforetip_pickup_moves()
.Closes RABR-431.
Test Plan
This branch can now be run on ABR3 to determine if the method call order is indeed the cause of the stall issue.
Changelog
Review requests
Risk assessment