Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): prevent stalls on PickUpTip Protocol API command #15663

Open
wants to merge 4 commits into
base: edge
Choose a base branch
from

Conversation

pmoegenburg
Copy link
Member

@pmoegenburg pmoegenburg commented Jul 15, 2024

Overview

Recently in ABR testing, we've seen significant stalls surface from the head boards. One possible culprit is _move_to_plunger_bottom() now occurring after tip_pickup_moves(). This PR moves _move_to_plunger_bottom() back to before tip_pickup_moves().

Closes RABR-431.

Test Plan

This branch can now be run on ABR3 to determine if the method call order is indeed the cause of the stall issue.

Changelog

Review requests

Risk assessment

@pmoegenburg pmoegenburg self-assigned this Jul 15, 2024
@pmoegenburg pmoegenburg requested a review from a team as a code owner July 15, 2024 19:58
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works I suppose I'll change my tune, but (a) I really don't understand a physical mechanism for this fixing that problem - how'd you come up with it? and (b) contra the pr description it doesn't seem like this call moved it seems like it disappeared, and now reappeared. Is there somewhere else that we have to remove it from? Are we moving twice now?

@pmoegenburg
Copy link
Member Author

This proposal comes from logic not physical first principles, i.e. stalls were occurring less with _move_to_plunger_bottom() prior to tip_pickup_moves() and stalls are occurring more without _move_to_plunger_bottom() prior to tip_pickup_movs(). The recent refactor mimics the previous code process (with prepare_for_aspirate() (which calls _move_to_plunger_bottom()) occurring after tip_pickup_moves()) with the exception of the first _move_to_plunger_bottom(), which was deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants