Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(app-shell): update user license agreement for desktop app installers #15631

Merged
merged 1 commit into from
Jul 18, 2024
Merged

feat(app-shell): update user license agreement for desktop app installers #15631

merged 1 commit into from
Jul 18, 2024

Conversation

shlokamin
Copy link
Member

Overview

Update the EULA text to latest rev from legal.

Risk assessment

Low

@shlokamin shlokamin requested a review from a team as a code owner July 11, 2024 19:01
@shlokamin shlokamin requested review from brenthagen, koji, ecormany, ncdiehl11 and sfoster1 and removed request for a team July 11, 2024 19:01
koji
koji approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

once quick question, will we need to update this text file, when we update Desktop?

@shlokamin
Copy link
Member Author

@koji nope, we just need to update this file when there are updates to the end user license agreement (which there should rarely be)

@shlokamin shlokamin merged commit fa23071 into edge Jul 18, 2024
27 checks passed
@shlokamin shlokamin deleted the app_shell-update-license-confirmation_v2_app-build branch July 18, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koji koji koji approved these changes

@brenthagen brenthagen Awaiting requested review from brenthagen brenthagen is a code owner automatically assigned from Opentrons/js

@ecormany ecormany Awaiting requested review from ecormany

@ncdiehl11 ncdiehl11 Awaiting requested review from ncdiehl11

@sfoster1 sfoster1 Awaiting requested review from sfoster1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shlokamin @koji