fix(hardware): gripper calibration fix #15630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -538,6 +537,8 @@ async def capacitive_probe( | |||
| """ | |||
| log_files: Dict[SensorId, str] = {} if not data_files else data_files | |||
| sensor_driver = SensorDriver() | |||
| pipette_present = tool is NodeId.pipette_left or tool is NodeId.pipette_right | |||
There was a problem hiding this comment.
pipette_present = tool is in [NodeId.pipette_left, NodeID.pipette_right]
There was a problem hiding this comment.
Looks good otherwise besides this little nit
ahiuchingau
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
There was a refactor a little while ago that sought to enable capacitive probing using the pipette for liquid level detection- in that endeavor we also broke the gripper's capacitive probing. This fixes that and should still allow us to do capacitive probing with a pipette.
Closes RQA-218
Changelog
toolentry to the move groups associated with the probing motionTest Plan