RQA-2830 fix mac dmg to be x64 binary and use x64 bundled python to pip install #15624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
shlokamin
approved these changes
Jul 11, 2024
sfoster1
approved these changes
Jul 11, 2024
|
validated https://builds.opentrons.com/app/Opentrons-v7.3.1-mac-b44980-RQA-2830-mac-python-package-app-build.dmg as well. merging. |
y3rsh
added a commit
that referenced
this pull request
Jul 22, 2024
…ip install (#15624) ## Replaces #15618 with PR against branch name ending in `app-build-internal` to trigger a build ## Overview - <https://opentrons.atlassian.net/browse/RQA-2830> - `macos-11` GitHub runner was intel and now we use macos-latest that is arm [doc](https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories) - specify --x64 argument to electron-builder - ~~per [doc](https://github.com/actions/setup-python?tab=readme-ov-file#supported-architectures) x64 python should be installed so the pip install will be the right platform. I'm not confident in this.~~ - see comment in #15618 - we need to use the python we download on mac to do the pip install so the installed packages match the platform correctly ## Test Plan - [x] build locally and see that it works - [x] watch CI and install the built package - [x] validate that once the package dmg is x64 that analysis works (python has packages with the right arch) # Review requests - This the right approach? # Risk assessment High because our .dmg currently cannot analyze protocols 2.0.0-alpha.0 internal release build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #15618 with PR against branch name ending in
app-build-internalto trigger a buildOverview
macos-11GitHub runner was intel and now we use macos-latest that is arm docper doc x64 python should be installed so the pip install will be the right platform. I'm not confident in this.Test Plan
Review requests
Risk assessment
High because our .dmg currently cannot analyze protocols 2.0.0-alpha.0 internal release build.