refactor(app): Componentize "intervention info" #15617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koji
reviewed
Jul 11, 2024
app/src/molecules/InterventionModal/InterventionContent/InterventionContent.stories.tsx
Outdated
Show resolved
Hide resolved
This is more than just move now, and it's not really a step.
Increasingly, we'll want some text that does or doesn't appear responsively, and we could do that with a wrapper but we could also just inject display: none in the same way we inject separate styles.
This will be helpful to visualize components that are standalone in storybook but always inside a container in practice
This component now is defined with the correct text styling, better names for things, and allows a labware nickname. Closes EXEC-530
Steal a util from the Command component to pull the user-defined nickname of a labware, if present.
This is a component that is a stack of stuff that lives in a left column often along side a deck map of some description. Closes EXEC-500
a14c461
to
b30f8d5
Compare
…entionContent.stories.tsx Co-authored-by: koji <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intervention info is the name of the grey block with the labware name and the labware icon, and this makes it a component and updates its style.
There's also a new content component called
InterventionInfoComponentthat mostly exists to hold the intervention info. This is used in Error Recovery, when you pick tips in a rack to pick up or tipracks to use.Review
Seem like good changes?
Testing
Storybook will be at https://s3-us-west-2.amazonaws.com/opentrons-components/exec-500-intervention-content/index.html?path=/docs/app-molecules-interventionmodal-interventioncontent-interventioncontent--docs
Closes EXEC-500
Closes EXEC-530