feat(app-shell): update desktop app user license agreement #15612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shlokamin |
|
Verified on Linux that EULA is displayed and app waits to load until it is accepted. |
|
@shlokamin, I noticed that the eulaAccepted file ends up going in ~/.config/opentrons/ instead of ~/.config/Opentrons. It doesn't affect the functionality but that file is all by its lonesome in that directory. |
|
@DerekMaggio huh that's interesting. as far as i can see where it gets stored is not configurable by electron-builder. thats weird though. thanks for testing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds an actual EULA generated by our Legal team to our desktop app installers for Mac, Linux, and Windows.
Closes AUTH-534
Mac build: https://builds.opentrons.com/app/Opentrons-v7.3.1-mac-b44920-app_shell-update-license-confirmation_app-build.dmg
Windows build: https://builds.opentrons.com/app/Opentrons-v7.3.1-win-b44920-app_shell-update-license-confirmation_app-build.exe
Linux build: https://builds.opentrons.com/app/Opentrons-v7.3.1-linux-b44920-app_shell-update-license-confirmation_app-build.AppImage
Changelog
Review requests
Make sure EULA confirmation shows up in our app installers before the app actually opens.
Risk assessment
Low