fix(app): ERSplash doesn't care about device #15601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know where in my brain this idea came from but both the ODD and the desktop want to show this screen.
sfoster1
requested review from
smb2268,
SyntaxColoring and
TamarZanzouri
and removed request for
a team
SyntaxColoring
approved these changes
Jul 9, 2024
| isOnDevice: boolean, | ||
| showERWizard: boolean | ||
| ): boolean { | ||
| export function useRunPausedSplash(showERWizard: boolean): boolean { | ||
| // Don't show the splash when desktop ER wizard is active. |
There was a problem hiding this comment.
Does this comment still match what's going on? showERWizard doesn't mean specifically the desktop ER wizard, does it?
There was a problem hiding this comment.
Good catch, it did not. Fixed up
syao1226
pushed a commit
that referenced
this pull request
Jul 10, 2024
I don't know where in my brain this idea came from but both the ODD and the desktop want to show this screen. ## testing - [x] enter ER on the desktop app and it shows a splash screen and a wizard when you click the "enter error recovery button"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know where in my brain this idea came from but both the ODD and the desktop want to show this screen.
testing