automatically assign IP and expected volume moved #15597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t item, changed code to match
… for a working ip grabber.
did not realize that the lint test was not passed
rclarke0
reviewed
Jul 8, 2024
|
|
||
|
|
||
| def get_protocol_step_as_int() -> Tuple[int, float, str]: | ||
| def get_protocol_step_as_int(storage_directory, robot) -> Tuple[int, float, str]: |
There was a problem hiding this comment.
def get_protocol_step_as_int(storage_directory: str, robot: str)
syao1226
pushed a commit
that referenced
this pull request
Jul 10, 2024
<!-- Thanks for taking the time to open a pull request! Please make sure you've read the "Opening Pull Requests" section of our Contributing Guide: https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#opening-pull-requests To ensure your code is reviewed quickly and thoroughly, please fill out the sections below to the best of your ability! --> # Overview <!-- Added section to read a json file in the measurement folder containing all robot IP's and expected volumes moved based on robot name.--> # Test Plan <!-- Tested steps 1, 2, and 3 with measurements. I do not believe more testing is needed. --> # Changelog <!-- - added json file reader for IP's and volumes - added recovery if "Y" or "N" were not input after a measurement --> # Review requests <!-- N/A --> # Risk assessment <!-- This script is not relied on in any other script. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Test Plan
Changelog
Review requests
Risk assessment