feat(robot-server): add protocol_kind query arg to GET protocols endpoint. #15589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
approved these changes
Jul 8, 2024
SyntaxColoring
requested changes
Jul 8, 2024
| @@ -453,6 +471,7 @@ async def get_protocols( | |||
| files=[ProtocolFile(name=f.path.name, role=f.role) for f in r.source.files], | |||
| ) | |||
| for r in protocol_resources | |||
| if (protocol_kind in [None, r.protocol_kind]) | |||
There was a problem hiding this comment.
Can we move this filtering into SQL? i.e. add a protocol_kind parameter to ProtocolStore.get_all()?
This can happen in another PR if it needs to, but it's generally easier to fix stuff like this earlier rather than later.
There was a problem hiding this comment.
Discussed in person and I think you mentioned you'll look into this in another PR.
SyntaxColoring
approved these changes
Jul 9, 2024
| @@ -453,6 +471,7 @@ async def get_protocols( | |||
| files=[ProtocolFile(name=f.path.name, role=f.role) for f in r.source.files], | |||
| ) | |||
| for r in protocol_resources | |||
| if (protocol_kind in [None, r.protocol_kind]) | |||
There was a problem hiding this comment.
Discussed in person and I think you mentioned you'll look into this in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The client app needs to filter out protocols based on their kind, this pull request allows that at the server side by adding a
protocolKindquery arg to theGET /protocolsendpoint.Closes: PLAT-330
Test Plan
standardprotocols are returned whenprotocolKind=standardquick-transferprotocols are returned whenprotocolKind=quick-transferprotocolKindis invalidChangelog
protocolKindquery arg to theGET /protocolsendpointReview requests
Risk assessment
Low, unreleased feature