feat(api): Enable error recovery without the feature flag #15588
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes EXEC-547.
Test Plan
opentrons_simulate
, local in-app analysis, and robot-side analysis still work as expected when the protocol has an error.Changelog
Stop gating error recovery behind the
enableErrorRecoveryExperiments
feature flag.The feature flag doesn't do anything anymore. I'm leaving it in-place in case we want to use it for the ongoing work in liquid level detection.
For things other than real robot-server protocol runs (including analysis,
opentrons_execute
, maintenance runs, etc.), explicitly choose a policy of "never recover."We don't ever want to enter recovery mode for these things, because nothing could bring it out of recovery mode, and it would hang forever.
Explicitly disable error recovery on the OT-2. None of the designs for the upcoming release make sense on an OT-2, because the OT-2 lacks the hardware feedback to detect the errors in the first place.
Review requests
Risk assessment
Medium.