feat(app): clone run with CSV file IDs #15550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When cloning a run, we scrape runtime parameter values from the cloned run and pass along non-default runtime parameters as overrides to the new run. We need to mirror this functionality for CSV runtime parameters by passing file IDs associated with a previous run when cloning the run. AUTH-457
aaron-kulkarni
pushed a commit
that referenced
this pull request
Jul 3, 2024
Closes AUTH-457 When cloning a run, we scrape runtime parameter values from the cloned run and pass along non-default runtime parameters as overrides to the new run. We need to mirror this functionality for CSV runtime parameters by passing file IDs associated with a previous run when cloning the run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes AUTH-457
Overview
When cloning a run, we scrape runtime parameter values from the cloned run and pass along non-default runtime parameters as overrides to the new run. We need to mirror this functionality for CSV runtime parameters by passing file IDs associated with a previous run when cloning the run.
Test Plan
Difficult to test right now without backend accepting CSV runtime parameter values at
/runsand/protocols. Please view updated test fileuseCloneRun.test.tsxChangelog
getRunTimeParameterValuesutil function to check for file ID associated withcsv_filetype runtime parametersChooseProtocolSlideoutandChooseRobotToRunProtocolSlideoutRisk assessment
low-medium