feat(app-shell): add temp user license agreement to app installer #15539
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlokamin
commented
Jun 27, 2024
Comment on lines
-205
to
+206
| const v21Config = MOCK_CONFIG_V22 | ||
| const result = migrate(v21Config) | ||
| const v22Config = MOCK_CONFIG_V22 | ||
| const result = migrate(v22Config) |
There was a problem hiding this comment.
forgot to fix this naming in my last PR so doing it now, it is unrelated to the rest of this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a temporary user license agreement confirmation to each of the desktop app installers (mac, linux, windows)
closes AUTH-534
Test Plan
Changelog
Review requests
Risk assessment