fix(protocol-designer): refine logic for change tip options being dis… #15512
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…abled
closes RESC-289
Overview
This bug is interesting. Basically the logic for the different change tip options needed to be refined because there were states when the selection was not disabled but you couldn't successfully set it. Looking at the logic, we needed to account for the well ratio being set. Since the introduction of the trash bin/waste chute, those entities are not labware and are addressable areas. So they don't have wells to select, therefore the certain option such as
perDest
andperSource
should be disabledTest Plan
Create a flex or ot-2 protocol with a single channel and an 8 channel. Add a 1 well reservoir and a 12 well reservoir.
Create a transfer step where you aspirate from the 1 well reservoir and dispense into the trash bin. See that the change tip dropdown's
per source
andper dest
are disabled. Now change the dispense location to 1 well/column in the 12 well reservoir. See that theper source
is enabled and selectable and theper dest
is still disabled. Then change the dispense location to 2 wells/columns in the 12 well reservoir. See that theper dest
is enabled but theper source
is disabled.Repeat those steps with the other pipette.
Note: only the move liquid form needed to be updated since the mix form does not allow you to mix into a trash bin or waste chute.
Changelog
Review requests
see test plan
Risk assessment
low