Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): refine logic for change tip options being dis… #15512

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Jun 25, 2024

…abled

closes RESC-289

Overview

This bug is interesting. Basically the logic for the different change tip options needed to be refined because there were states when the selection was not disabled but you couldn't successfully set it. Looking at the logic, we needed to account for the well ratio being set. Since the introduction of the trash bin/waste chute, those entities are not labware and are addressable areas. So they don't have wells to select, therefore the certain option such as perDest and perSource should be disabled

Test Plan

Create a flex or ot-2 protocol with a single channel and an 8 channel. Add a 1 well reservoir and a 12 well reservoir.

Create a transfer step where you aspirate from the 1 well reservoir and dispense into the trash bin. See that the change tip dropdown's per source and per dest are disabled. Now change the dispense location to 1 well/column in the 12 well reservoir. See that the per source is enabled and selectable and the per dest is still disabled. Then change the dispense location to 2 wells/columns in the 12 well reservoir. See that the per dest is enabled but the per source is disabled.

Repeat those steps with the other pipette.

Note: only the move liquid form needed to be updated since the mix form does not allow you to mix into a trash bin or waste chute.

Changelog

  • refine logic for when the change tip options are disabled

Review requests

see test plan

Risk assessment

low

@jerader jerader requested a review from a team as a code owner June 25, 2024 17:50
@jerader jerader requested review from koji and ncdiehl11 and removed request for a team June 25, 2024 17:51
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jerader jerader merged commit ff43837 into chore_release-pd-8.1.0 Jun 25, 2024
20 checks passed
@jerader jerader deleted the pd_bug-in-change-tip-option branch June 25, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants