Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix multichannel 384 well selection #15468

Merged
merged 8 commits into from
Jun 21, 2024

Conversation

brenthagen
Copy link
Contributor

Overview

selects only the intial well of a multichannel selection instead of all wells, so the correct commands are generated

Test Plan

verified multichannel quick transfers pass analysis

Changelog

  • Fixes multichannel 384 well selection

Review requests

  • check 8- and 96-channel 384 well selection for expected behavior
  • generate the quick transfer and initiate setup to verify analysis passes

Risk assessment

low

selects only the intial well of a multichannel selection instead of all wells, so the correct
commands are generated
@brenthagen brenthagen requested a review from a team June 20, 2024 15:28
@brenthagen brenthagen requested a review from a team as a code owner June 20, 2024 15:28
@brenthagen brenthagen requested review from TamarZanzouri and removed request for a team and TamarZanzouri June 20, 2024 15:28
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tested 8- and 96-channel pipetting into a 384 well plate and looks good. However, a single channel column selection selects 2 at a time which i'm not sure is expected?

Screen.Recording.2024-06-21.at.11.57.35.mov

@brenthagen
Copy link
Contributor Author

i tested 8- and 96-channel pipetting into a 384 well plate and looks good. However, a single channel column selection selects 2 at a time which i'm not sure is expected?

Screen.Recording.2024-06-21.at.11.57.35.mov

yep, that's a reversion, added back the single channel column select. thanks for catching

Copy link
Contributor

@smb2268 smb2268 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out with all 3 pipette configurations and it works as expected! I'll follow up with this ticket https://opentrons.atlassian.net/browse/PLAT-344 to adapt logic now that the length of the sourceWell and destWell arrays are no longer equal to the number of wells actually selected.

@brenthagen brenthagen merged commit 68d4f77 into edge Jun 21, 2024
20 checks passed
@brenthagen brenthagen deleted the app_fix-multichannel-384-well-selection branch June 21, 2024 21:56
nbshiland pushed a commit that referenced this pull request Jun 25, 2024
selects only the initial well of a multichannel selection instead of all wells, so the correct commands are generated

---------

Co-authored-by: smb2268 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants