Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(robot-server): Add failedCommandId to command summary model #15467

Merged
merged 1 commit into from
Jun 20, 2024
Merged

feat(robot-server): Add failedCommandId to command summary model #15467

merged 1 commit into from
Jun 20, 2024

Conversation

SyntaxColoring
Copy link
Contributor

Overview

Closes EXEC-571.

Test plan

None needed.

Changelog

  • Add failedCommandId to command summaries (GET /runs/{id}/commands).
  • Deduplicate the MaintenanceRunCommandSummary model with RunCommandSummary.

Review requests

None.

Risk assessment

Low.

@SyntaxColoring
Add failedCommandId to command summary model.
56474e9 
Deduplicate MaintenanceRunCommandSummary with RunCommandSummary.
@SyntaxColoring SyntaxColoring added the robot server Affects the `robot-server` project label Jun 20, 2024
@SyntaxColoring SyntaxColoring requested a review from a team as a code owner June 20, 2024 14:55
mjhuff
mjhuff approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! Thank you!

TamarZanzouri
TamarZanzouri approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@TamarZanzouri TamarZanzouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for picking this up!

@SyntaxColoring SyntaxColoring merged commit 93231a2 into edge Jun 20, 2024
17 checks passed
@SyntaxColoring SyntaxColoring deleted the add_failed_command_id_to_command_summary branch June 20, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TamarZanzouri TamarZanzouri TamarZanzouri approved these changes

@mjhuff mjhuff mjhuff approved these changes

Assignees
No one assigned
Labels
robot server Affects the `robot-server` project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SyntaxColoring @TamarZanzouri @mjhuff